[
https://issues.apache.org/jira/browse/SOLR-13300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788399#comment-16788399
]
Mark Miller commented on SOLR-13300:
------------------------------------
{noformat} HashMap to a ConcurrentHashMap (which doesn't support null keys) ...
although I'm not sure if that was something that he found was definitively
causing problems in other tests, or just something he thought was a "good idea"
and tried it.{noformat}
That change ended up being annoying, it was not for the hell of it. Tests often
don't respect shared base variables when they are not thread safe, timing
changes can expose those problems. It is a good idea to make those base
variables thread safe as a proper defense, but this skip stuff is a real
problem.
> Reproducing seed in master for DistributedFacetExistsSmallTest
> --------------------------------------------------------------
>
> Key: SOLR-13300
> URL: https://issues.apache.org/jira/browse/SOLR-13300
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Priority: Major
>
> ant test -Dtestcase=DistributedFacetExistsSmallTest -Dtests.method=test
> -Dtests.seed=662700D3AC576EAB -Dtests.slow=true -Dtests.badapples=true
> -Dtests.locale=ca -Dtests.timezone=Europe/Ulyanovsk -Dtests.asserts=true
> -Dtests.file.encoding=ISO-8859-1
> This test hasn't been changed lately, but reproduces 3/3 for me.
>
> {code:java}
> 2> NOTE: reproduce with: ant test
> -Dtestcase=DistributedFacetExistsSmallTest -Dtests.method=test
> -Dtests.seed=662700D3AC576EAB -Dtests.slow=true -Dtests.badapples=true
> -Dtests.locale=ca -Dtests.timezone=Europe/Ulyanovsk -Dtests.asserts=true
> -Dtests.file.encoding=ISO-8859-1
> [junit4] FAILURE 19.1s | DistributedFacetExistsSmallTest.test <<<
> [junit4] > Throwable #1: junit.framework.AssertionFailedError:
> .facet_counts.facet_fields.t_s.null:0!=null
> [junit4] > at
> __randomizedtesting.SeedInfo.seed([662700D3AC576EAB:EE733F0902AB0353]:0)
> [junit4] > at junit.framework.Assert.fail(Assert.java:57)
> [junit4] > at
> org.apache.solr.BaseDistributedSearchTestCase.compareSolrResponses(BaseDistributedSearchTestCase.java:999)
> [junit4] > at
> org.apache.solr.BaseDistributedSearchTestCase.compareResponses(BaseDistributedSearchTestCase.java:1026)
> [junit4] > at
> org.apache.solr.BaseDistributedSearchTestCase.query(BaseDistributedSearchTestCase.java:680)
> [junit4] > at
> org.apache.solr.BaseDistributedSearchTestCase.query(BaseDistributedSearchTestCase.java:643)
> [junit4] > at
> org.apache.solr.handler.component.DistributedFacetExistsSmallTest.checkRandomParams(DistributedFacetExistsSmallTest.java:139)
> [junit4] > at
> org.apache.solr.handler.component.DistributedFacetExistsSmallTest.test(DistributedFacetExistsSmallTest.java:87)
> [junit4] > at
> org.apache.solr.BaseDistributedSearchTestCase$ShardsRepeatRule$ShardsFixedStatement.callStatement(BaseDistributedSearchTestCase.java:1082)
> [junit4] > at
> org.apache.solr.BaseDistributedSearchTestCase$ShardsRepeatRule$ShardsStatement.evaluate(BaseDistributedSearchTestCase.java:1054)
> [junit4] > at java.lang.Thread.run(Thread.java:748)
> [junit4] 2> NOTE: leaving temporary files on disk at:
> /Users/Erick/apache/solrVersions/playspace/solr/build/solr-core/test/J0/temp/solr.handler.component.DistributedFacetExistsSmallTest_662700D3AC576EAB-001
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
