[
https://issues.apache.org/jira/browse/SOLR-13310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788404#comment-16788404
]
Mark Miller edited comment on SOLR-13310 at 3/9/19 12:25 AM:
-------------------------------------------------------------
bq. Maybe, but there is really no reason why there needs to be a "long lived"
facetExecutor
My comment is more general. Having noticed lots of kind of wasted executor
usage, I added a executor to the base test class and corecontainre and moved
all this little one off stuff to using those executors. We want them to help
discourage silly executor usage (static executors we dont shutdown or wait for,
tons of pools of threads without much reuse vs a few pools of threads) and give
easy access to a pool of threads for random work.
In this case, if you don't need the long live static facet executor, that's
fine.
was (Author: [email protected]):
bq. Maybe, but there is really no reason why there needs to be a "long lived"
facetExecutor
My comment is more general. Having noticed lots of kind of wasted executor
usage, I added a executor to the base test class and corecontainre and moved
all this little one off stuff to using those executors. We want them to help
discourage silly executor usage and give easy access to a pool of threads for
random work.
In this case, if you don't need the long live static facet executor, that's
fine.
> facet.threads is using the updateExecutor
> -----------------------------------------
>
> Key: SOLR-13310
> URL: https://issues.apache.org/jira/browse/SOLR-13310
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Hoss Man
> Priority: Major
>
> Had a WTF moment skimming some SimpleFacets code today...
> {code}
> this.facetExecutor =
> req.getCore().getCoreContainer().getUpdateShardHandler().getUpdateExecutor();
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
