[ 
https://issues.apache.org/jira/browse/SOLR-13310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788413#comment-16788413
 ] 

Hoss Man commented on SOLR-13310:
---------------------------------

I'm saying ideally we would have a long lived, shared, re-used (unbounded) 
*_threadpool_* as part of the core container lifecycle, that each facet request 
could wrap in a per-request *_Executor_* that was bounded by the 
{{facet.threads=N}} limit.

that way we could let executor worry about not exceeding the 
{{facet.threads=N}} limit, instead of the wonky code SimpleFacets uses today 
that expects an unbounded Executor but uses has runnables that gate themselves 
on a semaphore to ensure that we don't use too many concurrent threads.

> facet.threads is using the updateExecutor
> -----------------------------------------
>
>                 Key: SOLR-13310
>                 URL: https://issues.apache.org/jira/browse/SOLR-13310
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Hoss Man
>            Priority: Major
>
> Had a WTF moment skimming some SimpleFacets code today...
> {code}
>     this.facetExecutor = 
> req.getCore().getCoreContainer().getUpdateShardHandler().getUpdateExecutor();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to