[ https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088838#comment-13088838 ]
Robert Muir commented on LUCENE-3218: ------------------------------------- {quote} This looks really nice and easier to understand. {quote} I agree! At a glance, it seems this design looks much better to and avoids the sneaky delegation problems. Only one minor thing glancing at the patch: in MockDirectoryWrapper, can we track that the handle is actually closed? > Make CFS appendable > --------------------- > > Key: LUCENE-3218 > URL: https://issues.apache.org/jira/browse/LUCENE-3218 > Project: Lucene - Java > Issue Type: Improvement > Components: core/index > Affects Versions: 3.4, 4.0 > Reporter: Simon Willnauer > Priority: Blocker > Fix For: 3.4, 4.0 > > Attachments: LUCENE-3218.patch, LUCENE-3218.patch, LUCENE-3218.patch, > LUCENE-3218.patch, LUCENE-3218.patch, LUCENE-3218_3x.patch, > LUCENE-3218_test_fix.patch, LUCENE-3218_tests.patch > > > Currently CFS is created once all files are written during a flush / merge. > Once on disk the files are copied into the CFS format which is basically a > unnecessary for some of the files. We can at any time write at least one file > directly into the CFS which can save a reasonable amount of IO. For instance > stored fields could be written directly during indexing and during a Codec > Flush one of the written files can be appended directly. This optimization is > a nice sideeffect for lucene indexing itself but more important for DocValues > and LUCENE-3216 we could transparently pack per field files into a single > file only for docvalues without changing any code once LUCENE-3216 is > resolved. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org