s1monw commented on a change in pull request #581: LUCENE-3041: QueryVisitor
URL: https://github.com/apache/lucene-solr/pull/581#discussion_r265149100
##########
File path:
lucene/classification/src/java/org/apache/lucene/classification/utils/NearestFuzzyQuery.java
##########
@@ -327,4 +329,9 @@ private boolean equalsTo(NearestFuzzyQuery other) {
Objects.equals(fieldVals, other.fieldVals);
}
+ @Override
+ public void visit(QueryVisitor visitor, Predicate<String> fieldSelector) {
Review comment:
what's the advantage over asking the visitor if the field is accepted? I
also wonder if it can't just be an implementation detail of a specific visitor
if a field is of interest or not? It can be a simple delegate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
