cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second
grouping step if group.limit is 1 (aka Las Vegas Patch)
URL: https://github.com/apache/lucene-solr/pull/300#discussion_r265752410
##########
File path:
lucene/grouping/src/java/org/apache/lucene/search/grouping/SearchGroup.java
##########
@@ -48,9 +48,25 @@
* been passed to {@link FirstPassGroupingCollector#getTopGroups} */
public Object[] sortValues;
+ /** The top doc of this group: we track the Lucene id,
+ * the Solr id and the score of the document */
+ public Object topDocSolrId;
+ public float topDocScore;
+
Review comment:
I'm wondering about additional object/GC footprint (for anyone who does not
benefit from that) associated with the addition of three members here and
opened https://issues.apache.org/jira/browse/LUCENE-8728 to explore further
around that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
