[ https://issues.apache.org/jira/browse/SOLR-12120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795874#comment-16795874 ]
Jan Høydahl commented on SOLR-12120: ------------------------------------ I think there is still some work to do fleshing out the {{AuditEvent}} class to make it consistent. Right now the AuditType COMPLETED gives an impression that the request succeeded even if e.g. status=400. Requests that fail should always have type=ERROR. Another thing I see is that when you e.g. call the collections API to create a collection, we get two audit log entries, one for {{/admin/collection}} and another for {{/admin/cores}} which are sub requests. Should we somehow try to mask out such sub requests, and if yes, then how? > New plugin type AuditLoggerPlugin > --------------------------------- > > Key: SOLR-12120 > URL: https://issues.apache.org/jira/browse/SOLR-12120 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) > Components: security > Reporter: Jan Høydahl > Assignee: Jan Høydahl > Priority: Major > Time Spent: 3h > Remaining Estimate: 0h > > Solr needs a well defined plugin point to implement audit logging > functionality, which is independent from whatever {{AuthenticationPlugin}} or > {{AuthorizationPlugin}} are in use at the time. > It seems reasonable to introduce a new plugin type {{AuditLoggerPlugin}}. It > could be configured in solr.xml or it could be a third type of plugin defined > in {{security.json}}, i.e. > {code:java} > { > "authentication" : { "class" : ... }, > "authorization" : { "class" : ... }, > "auditlogging" : { "class" : "x.y.MyAuditLogger", ... } > } > {code} > We could then instrument SolrDispatchFilter to the audit plugin with an > AuditEvent at important points such as successful authentication: > {code:java} > auditLoggerPlugin.audit(new SolrAuditEvent(EventType.AUTHENTICATED, > request)); > {code} > We will mark the impl as {{@lucene.experimental}} in the first release to > let it settle as people write their own plugin implementations. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org