[ 
https://issues.apache.org/jira/browse/SOLR-13253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796346#comment-16796346
 ] 

ASF subversion and git services commented on SOLR-13253:
--------------------------------------------------------

Commit 8f25ded16f190de22f0d0816e12cf2a40eb19a83 in lucene-solr's branch 
refs/heads/branch_8x from David Wayne Smiley
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=8f25ded ]

SOLR-13253: avoid using IndexSchema.getResourceLoader for non-schema things.
Furthermore it's reference to SolrConfig was removed.

(cherry picked from commit 85a702cdff23a6352945dd78eb54ff6db68f6965)


> SolrResourceLoader of an IndexSchema should only be used for building the 
> schema stuff
> --------------------------------------------------------------------------------------
>
>                 Key: SOLR-13253
>                 URL: https://issues.apache.org/jira/browse/SOLR-13253
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Schema and Analysis
>            Reporter: David Smiley
>            Priority: Minor
>         Attachments: SOLR-13253.patch
>
>
> The IndexSchema has a SolrResourceLoader that's taken from a SolrConfig in 
> its constructor.  If this IndexSchema gets re-used across Solr cores (via 
> "shareSchema" being true in solr.xml), and if this resourceLoader is used in 
> the future from a core that differs from the core the schema was created 
> from, bad things can happen (like a memory leak in 
> SolrResourceLoader.waitingForResources).  The resourceLoader here is only 
> actually needed to help create the schema stuff, like analyzers.  Once it's 
> done, it isn't needed anymore. However our Solr code base is using this in 
> other places that are not appropriate.  It's a subtle problem as there's a 
> confluence of circumstances that need to occur to trigger it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to