diegoceccarelli commented on a change in pull request #300: SOLR-11831: Skip
second grouping step if group.limit is 1 (aka Las Vegas Patch)
URL: https://github.com/apache/lucene-solr/pull/300#discussion_r267291396
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java
##########
@@ -532,6 +578,12 @@ protected int groupedDistributedProcess(ResponseBuilder
rb) {
nextStage = ResponseBuilder.STAGE_DONE;
}
+ if (rb.stage == ResponseBuilder.STAGE_EXECUTE_QUERY &&
rb.getGroupingSpec().isSkipSecondGroupingStep()) {
+ shardRequestFactory = new StoredFieldsShardRequestFactory();
+ nextStage = ResponseBuilder.STAGE_DONE;
+ rb.stage = ResponseBuilder.STAGE_GET_FIELDS;
Review comment:
Thanks @cpoerschke, I agree that we should skip stages in the middle, I
merged your draft and later and I'm going to rerun the tests to see if it still
works as intended or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
