s1monw commented on a change in pull request #616: LUCENE-8734: Record
nextWriteGens in SegmentCommitInfo
URL: https://github.com/apache/lucene-solr/pull/616#discussion_r268151576
##########
File path: lucene/core/src/java/org/apache/lucene/index/SegmentCommitInfo.java
##########
@@ -91,16 +91,25 @@
* @param docValuesGen
* DocValues generation number (used to name doc-values updates
files)
*/
- public SegmentCommitInfo(SegmentInfo info, int delCount, int softDelCount,
long delGen, long fieldInfosGen, long docValuesGen) {
+ public SegmentCommitInfo(SegmentInfo info, int delCount, int softDelCount,
Review comment:
I think we should use the `setNext*Gen` setters instead of this. We need
them anyway and then we have only one way to set these values. It might also
make sense to assert that the next*Gen is > than the actual gen in these
setters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
