[
https://issues.apache.org/jira/browse/SOLR-13323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800312#comment-16800312
]
Gus Heck edited comment on SOLR-13323 at 3/25/19 12:37 AM:
-----------------------------------------------------------
heh didn't see the comment before I did the deps... I'll go convert that to
removal
was (Author: gus_heck):
heh didn't see the comment before I did the deps...
> Remove org.apache.solr.internal.csv.writer.CSVWriter (and related classes)
> --------------------------------------------------------------------------
>
> Key: SOLR-13323
> URL: https://issues.apache.org/jira/browse/SOLR-13323
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Affects Versions: master (9.0)
> Reporter: Gus Heck
> Priority: Minor
>
> This class appears to only be used in the test for itself. It's also easily
> confused with org.apache.solr.response.CSVWriter
> I propose we remove this class entirely. Is there any reason to believe from
> it's past history (of which I know nothing) that it might be depended upon by
> outside code and require a deprecation cycle?
> Presently it contains a System.out.println and a eclipse generated catch
> block that precommit won't like if we enable checking for System.out.println,
> which is why this ticket is a sub-task. If we do need to deprecate it then I
> propose we remove the print and simply re-throw the exception as a
> RuntimeException
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
