[ https://issues.apache.org/jira/browse/LUCENE-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801801#comment-16801801 ]
ASF subversion and git services commented on LUCENE-8735: --------------------------------------------------------- Commit b7de8cedefe538caaa464a273eda8e2070241c3d in lucene-solr's branch refs/heads/branch_8_0 from Simon Willnauer [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=b7de8ce ] LUCENE-8735: FilterDirectory.getPendingDeletions now delegates FilterDirectory.getPendingDeletions now forwards to the delegate even the method is not abstract in the super class. This prevents issues where our best effort in carrying on generations in the IndexWriter since pending deletions are swallowed by the FilterDirectory. > FileAlreadyExistsException after opening old commit > --------------------------------------------------- > > Key: LUCENE-8735 > URL: https://issues.apache.org/jira/browse/LUCENE-8735 > Project: Lucene - Core > Issue Type: Bug > Components: core/store > Affects Versions: 8.0 > Reporter: Henning Andersen > Priority: Major > Fix For: master (9.0) > > Time Spent: 40m > Remaining Estimate: 0h > > FilterDirectory.getPendingDeletes() does not delegate calls. This in turn > means that IndexFileDeleter does not consider those as relevant files. > When opening an IndexWriter for an older commit, excess files are attempted > deleted. If an IndexReader exists using one of the newer commits, the excess > files may fail to delete (at least on windows or when using the mocking > WindowsFS). > If then closing and opening the IndexWriter, the information on the pending > deletes are gone if a FilterDirectory derivate is used. At the same time, the > pending deletes are filtered out of listAll. This leads to a risk of hitting > an existing file name, causing a FileAlreadyExistsException. > This issue likely only exists on windows. > Will create pull request with fix. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org