I'm only passingly familiar with EmbeddedSolrServer. But if you can reproduce the problem using EmbeddedSolrServer, then that'd be a great place to start for a test. If you aren't able to reproduce the problem with EmbeddedSolrServer though, you'll probably need to use HttpSolrClient and one of the other test bases. Other test base options are RestTestBase or SolrJettyTestBase (see SolrJ's SchemaTest or TestBatchUpdate for examples of each of these.)
On Tue, Mar 26, 2019 at 10:03 AM Thomas Wöckinger <[email protected]> wrote: > > I know SolrJ pretty well, so should i write the against EmbeddedSolrServer, > or is there a different base class for such tests? > > On Tue, Mar 26, 2019 at 2:55 PM Jason Gerlowski <[email protected]> wrote: >> >> Hi Thomas, >> >> I see what you mean; the utilities used by that test as-is rely on >> XML. If you want to send the atomic-update via Javabin, the best >> option is probably to write a small testcase using SolrJ. Javabin is >> the default wire format in SolrJ, so it should do what you want. >> >> If you haven't used SolrJ much before, then this should give you a >> good overview: https://lucene.apache.org/solr/guide/7_7/using-solrj.html. >> As far as performing atomic-updates specifically, Yonik has an example >> on his blog post here that does an atomic update in SolrJ: >> http://yonik.com/solr/atomic-updates/ . Hopefully those two are enough >> to get you started. >> >> Lastly, I'll assign SOLR-13331 to myself and can help you with review >> once you take a first crack at a test. Feel free to bring up any >> other questions or places where you get stuck on the JIRA. (I'm more >> likely to see the notifications over there once I assign myself.) >> >> Best, >> >> Jason >> >> On Tue, Mar 26, 2019 at 7:30 AM Thomas Wöckinger >> <[email protected]> wrote: >> > >> > Following problem: >> > >> > TestHarness is using XMLLoader to test the whole test case, so it is not >> > possible to test with ByteArrayUtf8CharSequence because it will be >> > converted to String before. >> > >> > Can you guide me to create a TestHarness for which is using JavaBinCodec. >> > >> > Thx Tom >> > >> > On Mon, Mar 25, 2019 at 8:42 PM Erick Erickson <[email protected]> >> > wrote: >> >> >> >> Take a look at >> >> …/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdatesTest.java >> >> >> >> If you don’t want to add tests to that class, that’ll be (roughly) the >> >> place you’d add a new test class. >> >> >> >> Best, >> >> Erick >> >> >> >> > On Mar 25, 2019, at 9:54 AM, Thomas Wöckinger >> >> > <[email protected]> wrote: >> >> > >> >> > Hi! >> >> > >> >> > I submitted a patch for a solr bug >> >> > https://issues.apache.org/jira/browse/SOLR-13331, i also want to add >> >> > unit test for that issue. >> >> > >> >> > May someone can give me an advice where to add these unit test, because >> >> > a simple test can be made easy but i think there should be also some >> >> > integration tests, because the whole issue is heavy depending on the >> >> > used codec. >> >> > >> >> > Thx >> >> >> >> >> >> --------------------------------------------------------------------- >> >> To unsubscribe, e-mail: [email protected] >> >> For additional commands, e-mail: [email protected] >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
