[ https://issues.apache.org/jira/browse/LUCENE-8743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803028#comment-16803028 ]
Christine Poerschke commented on LUCENE-8743: --------------------------------------------- Attached proposed patch including adjustment to the test that LUCENE-8742 proposes to add. > lucene/queryparser DOMUtils.getAttributeOrFail(Element,String) never fails > -------------------------------------------------------------------------- > > Key: LUCENE-8743 > URL: https://issues.apache.org/jira/browse/LUCENE-8743 > Project: Lucene - Core > Issue Type: Bug > Reporter: Christine Poerschke > Assignee: Christine Poerschke > Priority: Minor > Attachments: LUCENE-8743.patch > > > https://docs.oracle.com/javase/8/docs/api/org/w3c/dom/Element.html#getAttribute-java.lang.String- > describes the {{Element.getAttribute}} return value as "The Attr value as a > string, or the empty string if that attribute does not have a specified or > default value." but {{DOMUtils.getAttributeOrFail}} only checks for {{null}} > and so it never fails. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org