janhoy commented on a change in pull request #626: SOLR-13353: Add SolrCli AuthTool test URL: https://github.com/apache/lucene-solr/pull/626#discussion_r270200579
########## File path: solr/core/src/test/org/apache/solr/util/AuthToolTest.java ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.util; + +import java.nio.file.Files; +import java.nio.file.Path; + +import org.apache.commons.cli.CommandLine; +import org.apache.solr.cloud.SolrCloudTestCase; +import org.junit.After; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Test; + +import static org.apache.solr.util.SolrCLI.findTool; +import static org.apache.solr.util.SolrCLI.parseCmdLine; + +/** + * Unit test for SolrCLI's AuthTool + */ +public class AuthToolTest extends SolrCloudTestCase { + private Path dir; + + @BeforeClass + public static void setupCluster() throws Exception { + configureCluster(1) + .addConfig("config", TEST_PATH().resolve("configsets").resolve("cloud-minimal").resolve("conf")) + .configure(); + } + + @Before + public void setUp() throws Exception { + super.setUp(); + dir = createTempDir("AuthToolTest").toAbsolutePath(); + } + + @After + public void tearDown() throws Exception { + super.tearDown(); + org.apache.commons.io.FileUtils.deleteDirectory(dir.toFile()); + } + + @Test + public void testEnableAuth() throws Exception { + Path solrIncludeFile = Files.createFile(dir.resolve("solrIncludeFile.txt")); Review comment: You could skip the setup() and tearDown() and instead create the tmpdir in the test method. No need to delete it, it should be deleted automatically on test suite termination. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
