dsmiley commented on a change in pull request #455: SOLR-12638
URL: https://github.com/apache/lucene-solr/pull/455#discussion_r270683816
##########
File path:
solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java
##########
@@ -83,6 +86,17 @@ public static boolean isAtomicUpdate(final AddUpdateCommand
cmd) {
return false;
}
+
+ /**
+ *
+ * @param sdoc doc to be updated
+ * @param rootDoc the root document
+ * @return whether sdoc's id equals to rootDoc's id
+ */
+ public boolean isRootDoc(SolrInputDocument sdoc, SolrInputDocument rootDoc) {
Review comment:
This method's signature is so weird and its implementation is short enough
that I wonder if you could simply just inline it and we'd be happier?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
