[ 
https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16808555#comment-16808555
 ] 

Uwe Schindler commented on LUCENE-8738:
---------------------------------------

I have some comment about the deprecation removal:

The {{Class#newInstance()}} stuff was replaced by 
{{clazz.getDeclaredConstructor().newInstance()}}. This is perfectly fine and 
also suggested in the deprecation notice. But I'd like to use 
{{getConstructor()}} instead, as we are only interested in "public" 
constructors.

We should also think about the fact that the code may now throw different 
exceptions. About the changes [~jpountz] did: Most code ways already wrapped 
with a general catch-all code, but maybe we can improve and unwrap runtime 
excetions from the InvocationTargetException. I will have a closer look again.

> Bump minimum Java version requirement to 11
> -------------------------------------------
>
>                 Key: LUCENE-8738
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8738
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/build
>            Reporter: Adrien Grand
>            Priority: Minor
>              Labels: Java11
>             Fix For: master (9.0)
>
>
> See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to