[ 
https://issues.apache.org/jira/browse/LUCENE-8726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16810175#comment-16810175
 ] 

Rupendra Peddacama commented on LUCENE-8726:
--------------------------------------------

[~ctargett] [~romseygeek]

Could you please check the patch for the branch_7_7. I have tried applying the 
patch and running "ant test", it failed with the following two errors:

 
{code:java}
// code placeholder

    [javac] 
/Users/rpeddacama/Desktop/lucene-solr/lucene/queries/src/java/org/apache/lucene/queries/function/ValueSource.java:290:
 error: cannot find symbol
    [javac]       this.searcher = searcher;
    [javac]           ^
    [javac]   symbol: variable searcher
    [javac] 
/Users/rpeddacama/Desktop/lucene-solr/lucene/queries/src/java/org/apache/lucene/queries/function/ValueSource.java:290:
 error: cannot find symbol
    [javac]       this.searcher = searcher;
    [javac]                       ^
    [javac]   symbol:   variable searcher
    [javac]   location: class FromDoubleValuesSource
{code}
   

> WrappedDoubleValuesSource can leak IndexSearcher references
> -----------------------------------------------------------
>
>                 Key: LUCENE-8726
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8726
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Major
>             Fix For: 7.7.2, 8.1
>
>         Attachments: LUCENE-8726.patch
>
>
> Cause of SOLR-13315
> Index-specific DoubleValuesSources can be created by 
> DoubleValuesSource.rewrite(), and the various consumers of these sources are 
> careful not to store these rewritten sources on long-lived objects, such as 
> queries that may be re-used between searchers.  However, the bridge code 
> between ValueSource and DoubleValuesSource does not return a new object from 
> its rewrite method, instead caching the passed-in IndexSearcher, which means 
> references to this searcher may leak.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to