uschindler commented on issue #618: #Lucene-2562: Make Luke a Lucene/Solr Module URL: https://github.com/apache/lucene-solr/pull/618#issuecomment-480483843 Hi @mocobeta, to me all looks fine. Let's wait a day or two and let us merge it into Lucene master, so others can comment. We can then proceed with more improvements separately. So I am +1 to merge! There are some smaller UI issues, especially with font sized and wrapping on Windows with 150% HiDPI: when building a custom analyzer the text of the actual components is huge and it may be better to show tokenfilters as a larger listview instead of one line. If you want to change this over the weekend, go ahead, but that does not limit us, as code is fine:  One other small improvement: It shows the Lucene version as title (in the form like saved in index), so it does not contain "dev"/"snapshot"/... Thats fine for the title of main window and about box. In the "AboutForm", it would be good to add another line of text next to credits with the full version string (Solr also shows this): `LucenePackage.get().getImplementationVersion()` - if it's not null (inside IDEs it may be null when no JAR file is built; this command reads the JAR file, so add proper null check). I just wanted to say: Eclipse IDE works fine after running "ant eclipse". I also built the lucene.zip/tgz file and was able to start luke from there. forbiddenapis works, "ant veroify" is also fine. Javadocs look OK.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
