jpountz commented on a change in pull request #637: LUCENE-8754: Prevent ConcurrentModificationException in SegmentInfo URL: https://github.com/apache/lucene-solr/pull/637#discussion_r272899650
########## File path: lucene/core/src/java/org/apache/lucene/index/SegmentInfo.java ########## @@ -68,7 +69,7 @@ private Map<String,String> diagnostics; - private final Map<String,String> attributes; + private Map<String,String> attributes; Review comment: Do we need to make it volatile so that toString sees the up-to-date reference to the attributes? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
