diegoceccarelli commented on a change in pull request #636: SOLR-10409 - Added
support for rows=x in /export to limit number of docs exported (With unit tests)
URL: https://github.com/apache/lucene-solr/pull/636#discussion_r274355703
##########
File path: solr/core/src/java/org/apache/solr/handler/export/ExportWriter.java
##########
@@ -251,13 +260,13 @@ protected int transferBatchToArrayForOutput(SortQueue
queue, SortDoc[] destinati
destinationArr[++outDocsIndex] = s;
}
}
-
return outDocsIndex;
}
- protected void addDocsToItemWriter(List<LeafReaderContext> leaves,
IteratorWriter.ItemWriter writer, SortDoc[] docsToExport, int outDocsIndex)
throws IOException {
+ protected void addDocsToItemWriter(List<LeafReaderContext> leaves,
IteratorWriter.ItemWriter writer, SortDoc[] docsToExport, int outDocsIndex, int
numDocsToExclude) throws IOException {
Review comment:
you are changing the interface here, are you sure you really really need to
do that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
