[
https://issues.apache.org/jira/browse/SOLR-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817027#comment-16817027
]
Uwe Schindler commented on SOLR-13400:
--------------------------------------
+1 patch looks fine.
I think adoption to jdk 11 is now trivial, as most of the patch is already
there. Do we plan to simplify this also in Solr 8.1 ?
> Replace Obeservable pattern in TransientSolrCoreCache
> -----------------------------------------------------
>
> Key: SOLR-13400
> URL: https://issues.apache.org/jira/browse/SOLR-13400
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Server, SolrCloud
> Affects Versions: 8.0, master (9.0)
> Reporter: Uwe Schindler
> Assignee: Erick Erickson
> Priority: Major
> Attachments: SOLR-13400.patch
>
>
> Due to change to Java 11 as minimum version (LUCENE-8738), the usage of the
> old java.utilObservable pattern is deprecated and cannot be used anymore in
> Lucene/Solr.
> LUCENE-8738 added a rewritten, more type-safe oimplementation of the observer
> pattern, but it looks like the is overengenieered. As there is only one
> listener registered, it would be enough to just call the method on SolrCores
> class (pkg-protected). On LUCENE-8738, [~erickerickson] suggested to move the
> callback method to queue closes of core in CoreContainer instead, so all the
> abstractions can be removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
