[
https://issues.apache.org/jira/browse/SOLR-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817166#comment-16817166
]
Erick Erickson commented on SOLR-13400:
---------------------------------------
yeah, I'll backport this to 8, there's no good reason not to.
And your Javadocs comment is well taken, I have to go over it all, I wanted to
see if it was as straightforward as I thought.
And, precommit and test both return SUCCESS.
Thanks again for pointing this out. I've been assuming that doing this after
the Java 11 push is the way to go, but that's not essential, whatever you would
find easiest. I know, doing this originally would have been easiest, ;)
> Replace Observable pattern in TransientSolrCoreCache
> ----------------------------------------------------
>
> Key: SOLR-13400
> URL: https://issues.apache.org/jira/browse/SOLR-13400
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Server, SolrCloud
> Affects Versions: 8.0, master (9.0)
> Reporter: Uwe Schindler
> Assignee: Erick Erickson
> Priority: Major
> Attachments: SOLR-13400.patch
>
>
> Due to change to Java 11 as minimum version (LUCENE-8738), the usage of the
> old java.utilObservable pattern is deprecated and cannot be used anymore in
> Lucene/Solr.
> LUCENE-8738 added a rewritten, more type-safe oimplementation of the observer
> pattern, but it looks like the is overengenieered. As there is only one
> listener registered, it would be enough to just call the method on SolrCores
> class (pkg-protected). On LUCENE-8738, [~erickerickson] suggested to move the
> callback method to queue closes of core in CoreContainer instead, so all the
> abstractions can be removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
