[
https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822646#comment-16822646
]
Tomoko Uchida commented on LUCENE-8738:
---------------------------------------
Locale-spacific failure report:
After checking out master branch, {{ant precommit}} fails on my PC (fedora
linux) with this error.
{code:java}
-documentation-lint:
[echo] checking for broken html...
[jtidy] FIXME: Broken HTML checks were disabled, as jtidy can't handle
HTML5.
[echo] Checking for broken links...
[exec]
[exec] Crawl/parse...
[exec]
[exec] Verify...
[echo] Checking for missing docs...
[exec] Traceback (most recent call last):
[exec] File
"/home/moco/repo/lucene-solr/dev-tools/scripts/checkJavaDocs.py", line 387, in
<module>
[exec] if checkPackageSummaries(sys.argv[1], level):
[exec] File
"/home/moco/repo/lucene-solr/dev-tools/scripts/checkJavaDocs.py", line 361, in
checkPackageSummaries
[exec] if (level == 'class' or level == 'method') and
checkSummary('%s/package-summary.html' % dirPath):
[exec] File
"/home/moco/repo/lucene-solr/dev-tools/scripts/checkJavaDocs.py", line 311, in
checkSummary
[exec] raise RuntimeError('BUG: failed to locate description in %s' %
fullPath)
[exec] RuntimeError: BUG: failed to locate description in
build/docs/analyzers-kuromoji/org/apache/lucene/analysis/ja/package-summary.html
BUILD FAILED
{code}
As far as I found, seems JDK11's {{javadoc}} tool ignores the "-locale en_US"
parameter (on both of fedora linux and windows) and Javadocs is generated with
default locale (in my case, "ja_JP") by ant {{documentation}} target, so the
python linter failed.
I use JDK 11.0.2.
{code}
java -version
openjdk version "11.0.2" 2019-01-15
OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.2+9)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.2+9, mixed mode)
{code}
And this (dirty) patch works for me anyway...
{code:xml}
--- a/lucene/common-build.xml
+++ b/lucene/common-build.xml
@@ -184,7 +184,7 @@
<property name="javadoc.noindex" value="true"/>
<!---TODO: Fix accessibility (order of H1/H2/H3 headings), see
https://issues.apache.org/jira/browse/LUCENE-8729 -->
- <property name="javadoc.doclint.args" value="-Xdoclint:all
-Xdoclint:-missing -Xdoclint:-accessibility"/>
+ <property name="javadoc.doclint.args" value="-Xdoclint:all
-Xdoclint:-missing -Xdoclint:-accessibility -J-Duser.language=en
-J-Duser.country=US"/>
<!---proc:none was added because of LOG4J2-1925 / JDK-8186647 -->
<property name="javac.doclint.args" value="-Xdoclint:all/protected
-Xdoclint:-missing -Xdoclint:-accessibility -proc:none"/>
{code}
> Bump minimum Java version requirement to 11
> -------------------------------------------
>
> Key: LUCENE-8738
> URL: https://issues.apache.org/jira/browse/LUCENE-8738
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/build
> Reporter: Adrien Grand
> Assignee: Uwe Schindler
> Priority: Minor
> Labels: Java11
> Fix For: master (9.0)
>
> Attachments: LUCENE-8738-solr-CoreCloseListener.patch,
> LUCENE-8738.patch
>
>
> See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
