In the middle of writing a test base, i realized that the SolrJettyTestBase is using an EmbeddedSolrServer as its fallback.
So two questions: 1.: Should i introduce a new EmbeddedSolrServerTestBase to clarify which implementations is used behind the scenes? 2.: I think it is a good idea two refactor EmbeddedSolrServer to use different codecs beside JavaBinCodec? Best, Tom On Thu, May 2, 2019 at 1:01 PM Thomas Wöckinger <[email protected]> wrote: > Ok, thx for your fast response, i will start now, hope to be finished in > two days. > > Best, > > Tom > > On Thu, May 2, 2019 at 12:59 PM Jason Gerlowski <[email protected]> > wrote: > >> Hi Thomas, >> >> No need to open a new issue. I added a few tests when I committed a >> fix on SOLR-13331 a few weeks back. I backported this change and it >> should be fixed in 7.7.2 when that is released. >> >> The project could always use additional tests though, so if you want >> to add an EmbeddedSolrServer test, just upload a patch to SOLR-13331, >> and I'll take a look. (Might help if you tag me in your post there). >> >> Best, >> >> Jason >> >> On Thu, May 2, 2019 at 5:36 AM Thomas Wöckinger >> <[email protected]> wrote: >> > >> > As i already commented on the issue SOLR-13331, i am starting writing >> test on this issue using EmbbededSolrServer, i didn't had time the last few >> weeks, should i open a new issue for this? >> > >> > I think backporting this to 7.x is also a good idea! >> > >> > On Tue, Mar 26, 2019 at 3:46 PM Jason Gerlowski <[email protected]> >> wrote: >> >> >> >> I'm only passingly familiar with EmbeddedSolrServer. But if you can >> >> reproduce the problem using EmbeddedSolrServer, then that'd be a great >> >> place to start for a test. If you aren't able to reproduce the >> >> problem with EmbeddedSolrServer though, you'll probably need to use >> >> HttpSolrClient and one of the other test bases. Other test base >> >> options are RestTestBase or SolrJettyTestBase (see SolrJ's SchemaTest >> >> or TestBatchUpdate for examples of each of these.) >> >> >> >> On Tue, Mar 26, 2019 at 10:03 AM Thomas Wöckinger >> >> <[email protected]> wrote: >> >> > >> >> > I know SolrJ pretty well, so should i write the against >> EmbeddedSolrServer, or is there a different base class for such tests? >> >> > >> >> > On Tue, Mar 26, 2019 at 2:55 PM Jason Gerlowski < >> [email protected]> wrote: >> >> >> >> >> >> Hi Thomas, >> >> >> >> >> >> I see what you mean; the utilities used by that test as-is rely on >> >> >> XML. If you want to send the atomic-update via Javabin, the best >> >> >> option is probably to write a small testcase using SolrJ. Javabin is >> >> >> the default wire format in SolrJ, so it should do what you want. >> >> >> >> >> >> If you haven't used SolrJ much before, then this should give you a >> >> >> good overview: >> https://lucene.apache.org/solr/guide/7_7/using-solrj.html. >> >> >> As far as performing atomic-updates specifically, Yonik has an >> example >> >> >> on his blog post here that does an atomic update in SolrJ: >> >> >> http://yonik.com/solr/atomic-updates/ . Hopefully those two are >> enough >> >> >> to get you started. >> >> >> >> >> >> Lastly, I'll assign SOLR-13331 to myself and can help you with >> review >> >> >> once you take a first crack at a test. Feel free to bring up any >> >> >> other questions or places where you get stuck on the JIRA. (I'm >> more >> >> >> likely to see the notifications over there once I assign myself.) >> >> >> >> >> >> Best, >> >> >> >> >> >> Jason >> >> >> >> >> >> On Tue, Mar 26, 2019 at 7:30 AM Thomas Wöckinger >> >> >> <[email protected]> wrote: >> >> >> > >> >> >> > Following problem: >> >> >> > >> >> >> > TestHarness is using XMLLoader to test the whole test case, so it >> is not possible to test with ByteArrayUtf8CharSequence because it will be >> converted to String before. >> >> >> > >> >> >> > Can you guide me to create a TestHarness for which is using >> JavaBinCodec. >> >> >> > >> >> >> > Thx Tom >> >> >> > >> >> >> > On Mon, Mar 25, 2019 at 8:42 PM Erick Erickson < >> [email protected]> wrote: >> >> >> >> >> >> >> >> Take a look at >> …/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdatesTest.java >> >> >> >> >> >> >> >> If you don’t want to add tests to that class, that’ll be >> (roughly) the place you’d add a new test class. >> >> >> >> >> >> >> >> Best, >> >> >> >> Erick >> >> >> >> >> >> >> >> > On Mar 25, 2019, at 9:54 AM, Thomas Wöckinger < >> [email protected]> wrote: >> >> >> >> > >> >> >> >> > Hi! >> >> >> >> > >> >> >> >> > I submitted a patch for a solr bug >> https://issues.apache.org/jira/browse/SOLR-13331, i also want to add >> unit test for that issue. >> >> >> >> > >> >> >> >> > May someone can give me an advice where to add these unit >> test, because a simple test can be made easy but i think there should be >> also some integration tests, because the whole issue is heavy depending on >> the used codec. >> >> >> >> > >> >> >> >> > Thx >> >> >> >> >> >> >> >> >> >> >> >> >> --------------------------------------------------------------------- >> >> >> >> To unsubscribe, e-mail: [email protected] >> >> >> >> For additional commands, e-mail: [email protected] >> >> >> >> >> >> >> >> >> >> >> --------------------------------------------------------------------- >> >> >> To unsubscribe, e-mail: [email protected] >> >> >> For additional commands, e-mail: [email protected] >> >> >> >> >> >> >> --------------------------------------------------------------------- >> >> To unsubscribe, e-mail: [email protected] >> >> For additional commands, e-mail: [email protected] >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >>
