[
https://issues.apache.org/jira/browse/LUCENE-8789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832409#comment-16832409
]
Tomoko Uchida commented on LUCENE-8789:
---------------------------------------
Sorry, my explanation was not sufficient...
{quote}If the 3rd party library makes the UI usable under java 8, where it
would otherwise be an unusable experience, I think that is a no-brainer, we
should use it.
{quote}
Even with the 3rd party library, Luke is not usable with the combination of
Java 8 and high dpi on Windows like the screenshot (the window and font is too
small so users have to expand it manually):
!sc_luke_java8.png|width=283,height=207!
This was fixed in Java 9, but it looks like (to me) some small glitches are
still remained. So anyway we need both of Java 9+ and the 3rd party library to
provide neat, stress-free user experience to Windows users (just as Mac guys
see).
bq. I don't see any licensing issue, so to me it seems to just be a judgement
call related to who is or isn't maintaining the third party package (last
released August 2018)? We can always remove this dependency in the future
because of how it plugs in, and we'll just fall back to the default
look-and-feel, so I don't think we need to be really paranoid in this situation.
Thanks, I agree to this point.
> Use JGoodies' look&feel for Luke on Windows platform
> ----------------------------------------------------
>
> Key: LUCENE-8789
> URL: https://issues.apache.org/jira/browse/LUCENE-8789
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/luke
> Reporter: Tomoko Uchida
> Assignee: Tomoko Uchida
> Priority: Minor
> Attachments: LUCENE-8789.patch, Luke_ Lucene Toolbox Project - v9.0.0
> 2019_05_02 11_45_14.png, Luke_ Lucene Toolbox Project - v9.0.0 2019_05_02
> 11_53_37.png, sc_luke_java8.png
>
>
> JGoodies Looks ([http://www.jgoodies.com/freeware/libraries/looks/]) is a
> Swing look&feel library for Windows platform.
> The main advantage of the library is (quoted from their home page):
> {quote}Our Windows look&feel focuses on a precise emulation on Windows XP,
> Vista, 7, 8, 8.1, and now Windows 10 in the following areas: menus, icons,
> colors, borders, fonts, font sizes, insets, and widget dimensions. It honors
> the screen resolution (low vs. high dpi) to adjust sizes, insets, and widget
> dimensions.
> {quote}
> The library works fine on Java11, relatively light weight (400KB), has no
> other external dependencies, and distributed under 2-Clause BSD License (see:
> [http://www.jgoodies.com/downloads/libraries/]).
>
> Actually, I forgot to include this when migrating Luke from the GitHub repo
> to Lucene project... :)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]