[
https://issues.apache.org/jira/browse/SOLR-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832728#comment-16832728
]
Christine Poerschke commented on SOLR-13049:
--------------------------------------------
Finally returning to this ticket ... thanks [~slivotov] for your input!
Attached patch passes {{ant precommit}} (including {{ant
check-forbidden-apis}}) on the current master branch after four straightforward
{code}
- defaultValue = new Float(0.5f);
+ defaultValue = Float.valueOf(0.5f);
{code}
style replacements. {{cd solr/contrib/ltr ; ant beast -Dbeast.iters=10}} also
passed.
If there are no further comments, questions, concerns, etc. then I'll aim to
commit this patch next week.
> make contrib/ltr Feature.defaultValue configurable
> --------------------------------------------------
>
> Key: SOLR-13049
> URL: https://issues.apache.org/jira/browse/SOLR-13049
> Project: Solr
> Issue Type: New Feature
> Components: contrib - LTR
> Reporter: Stanislav Livotov
> Priority: Major
> Attachments: SOLR-13049.patch, SOLR-13049.patch
>
>
> [~slivotov] wrote in SOLR-12697:
> {quote}
> I had also done a couple of additional code changes:
> 1. fixed small issue with defaultValue(previously it was impossible to set it
> from feature.json, and the tests were written where Feature was created
> manually, and not by parsing json). Tests are added which are validating
> defaultValue from schema field configuration and from a feature default value.
> {quote}
> (Please see
> https://issues.apache.org/jira/browse/SOLR-12697?focusedCommentId=16708618&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16708618
> for more context.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
