[ 
https://issues.apache.org/jira/browse/LUCENE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834612#comment-16834612
 ] 

Atri Sharma commented on LUCENE-7840:
-------------------------------------

[~jim.ferenczi] Attached an updated patch. Let me know if it looks fine.

 

An addition is to not return early from rewrite when there are no MUST clauses, 
but to return early when there are no MUST clauses and SHOULD clauses need not 
be rewritten.

[^LUCENE-7840.patch]

> BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least 
> 1 MUST/FILTER clause and 0==minShouldMatch
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-7840
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7840
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Hoss Man
>            Priority: Major
>         Attachments: LUCENE-7840.patch, LUCENE-7840.patch
>
>
> I haven't thought this through completely, let alone write up a patch / test 
> case, but IIUC...
> We should be able to optimize  {{ BooleanQuery rewriteNoScoring() }} so that 
> (after converting MUST clauses to FILTER clauses) we can check for the common 
> case of {{0==getMinimumNumberShouldMatch()}} and throw away any SHOULD 
> clauses as long as there is is at least one FILTER clause.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to