[ https://issues.apache.org/jira/browse/SOLR-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16842048#comment-16842048 ]
Lucene/Solr QA commented on SOLR-13474: --------------------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 11s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green} 1m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green} 1m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green} 1m 56s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 44m 26s{color} | {color:green} core in the patch passed. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 51m 31s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | SOLR-13474 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12968954/SOLR-13474.patch | | Optional Tests | compile javac unit ratsources checkforbiddenapis validatesourcepatterns | | uname | Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | ant | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh | | git revision | master / b9db118e | | ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 | | Default Java | LTS | | Test Results | https://builds.apache.org/job/PreCommit-SOLR-Build/395/testReport/ | | modules | C: solr/core U: solr/core | | Console output | https://builds.apache.org/job/PreCommit-SOLR-Build/395/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > Fix "Search is temporarily disabled" logic to be consistent for entire request > ------------------------------------------------------------------------------ > > Key: SOLR-13474 > URL: https://issues.apache.org/jira/browse/SOLR-13474 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Hoss Man > Assignee: Hoss Man > Priority: Major > Attachments: SOLR-13474.patch, SOLR-13474.patch > > > Where/How the "Search is temporarily disabled" logic was added in SOLR-12999 > can result in some weird failure cases (examples: SOLR-13470 & SOLR-13471) > due to the fact that (as currently implemented) some portions of processing > a SolrQueryRequest may see a valid searcher, but later other code paths will > get an error when trying to use the same searcher. > I think it would make more sense to move the "searchEnabled" logic out of > {{SolrQueryRequestbase.getSearcher()}} and into {{SolrCore.getSearcher()}} > (removing the need for {{SolrCore.isSearchEnabled()}} ). > This will: > * restore the long standing (and widly assumed by code) behavior of > {{SolrQueryRequestbase.getSearcher()}} that it will always return a > consistent result > * ensure that any custom plugins trying to call {{SolrCore.getSearcher()}} > directly will also get the benefits of the safety checks introduced in > SOLR-12999 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org