[ 
https://issues.apache.org/jira/browse/LUCENE-8793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843392#comment-16843392
 ] 

Tomoko Uchida commented on LUCENE-8793:
---------------------------------------

Hi Ohtani san,

thanks for updating the patch, I looked through the code. I'd like to do some 
small layout adjustment and refactoring (e.g. move table model classes from the 
Operator interfaces to the concrete Provider classes) on my local branch before 
committing it to the master, but as a whole it looks fine to me.

[~thetaphi]: Would you please look over the newly added method 
{{o.a.l.luke.models.analysis.AnalysisImpl#analyzeStepByStep(String)}}? There 
are some tricks partially copied from Solr's 
{{o.a.s.handler.AnalysisRequestHandlerBase}} to debug token streams, and I'm 
not confident in pushing the changes as is.

> Enhanced UI for CustomAnalyzer : show analysis steps
> ----------------------------------------------------
>
>                 Key: LUCENE-8793
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8793
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/luke
>            Reporter: Jun Ohtani
>            Assignee: Tomoko Uchida
>            Priority: Minor
>         Attachments: LUCENE-8793-2.patch, LUCENE-8793.patch, 
> LUCENE-8793.patch, Screen Shot 2019-05-06 at 10.00.57.png, Screen Shot 
> 2019-05-07 at 1.40.47.png, Screenshot from 2019-05-06 13-45-40.png, 
> Screenshot from 2019-05-06 13-46-16.png
>
>
> This is a migrated issue from previous Luke project in GitHub: 
> [https://github.com/DmitryKey/luke/issues/134]
>  
> For on-the-fly inspection / debugging, it is desirable to show the more 
> detailed step by step information in the Custom Analyzer UI.
> This will be just like Solr's Analysis screen,
> [https://lucene.apache.org/solr/guide/7_5/analysis-screen.html]
> or Elasticsearch's {{_analyze}} API and Kibana's Analyzer UI.
> [https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-analyze.html]
> [https://github.com/johtani/analyze-api-ui-plugin]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to