janhoy commented on issue #665: Fixes SOLR-11841, SOLR-13331, SOLR-13347 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-493920365 It looks trivial to do a separate PR for SOLR-13347. Please do that if possible and let's avoid huge multi-issue patches. I am still confused by unrelated formatting changes, consider opening a new JIRA and PR for those, I'm sure someone will take a look at it :) You might want to review the contributor guide: https://wiki.apache.org/solr/HowToContribute#Creating_the_patch_file
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org