[ 
https://issues.apache.org/jira/browse/LUCENE-8804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844187#comment-16844187
 ] 

ASF subversion and git services commented on LUCENE-8804:
---------------------------------------------------------

Commit ec6ac9756c3acf5f8151a2c28adc9750478c50c6 in lucene-solr's branch 
refs/heads/master from Adrien Grand
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ec6ac97 ]

LUCENE-8804: Forbid calls to putAttribute on frozen FieldType instances.


> FieldType attribute map should not be modifiable after freeze
> -------------------------------------------------------------
>
>                 Key: LUCENE-8804
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8804
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/index
>    Affects Versions: 8.0
>            Reporter: Vamshi Vijay Nakkirtha
>            Priority: Minor
>              Labels: features, patch
>             Fix For: master (9.0), 8.2
>
>         Attachments: LUCENE-8804.01.patch, LUCENE-8804.patch
>
>
> Today FieldType attribute map can be modifiable even after freeze. For all 
> other properties of FieldType, we do "checkIfFrozen()" before making the 
> update to the property but for attribute map, we does not seem to make such 
> check. 
>  
> [https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.0.0/lucene/core/src/java/org/apache/lucene/document/FieldType.java#L363]
> we may need to add check at the beginning of the function similar to other 
> properties setters.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to