thomaswoeckinger commented on a change in pull request #665: Fixes SOLR-11841,
SOLR-13331, SOLR-13347
URL: https://github.com/apache/lucene-solr/pull/665#discussion_r286842053
##########
File path: solr/core/src/java/org/apache/solr/handler/loader/XMLLoader.java
##########
@@ -178,13 +183,12 @@ public void load(SolrQueryRequest req, SolrQueryResponse
rsp, ContentStream stre
final byte[] body = IOUtils.toByteArray(is);
// TODO: The charset may be wrong, as the real charset is later
// determined by the XML parser, the content-type is only used as a
hint!
- log.trace("body", new String(body, (charset == null) ?
- ContentStreamBase.DEFAULT_CHARSET : charset));
+ log.trace("body", new String(body, (charset == null) ?
ContentStreamBase.DEFAULT_CHARSET : charset));
IOUtils.closeQuietly(is);
is = new ByteArrayInputStream(body);
}
- parser = (charset == null) ?
- inputFactory.createXMLStreamReader(is) :
inputFactory.createXMLStreamReader(is, charset);
+ parser = (charset == null) ? inputFactory.createXMLStreamReader(is)
Review comment:
As i mentioned above if you select next to last in the commit view, it is
easy to review, formatting is done only in the last commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
