risdenk commented on a change in pull request #685: SOLR-13434: OpenTracing
support for Solr
URL: https://github.com/apache/lucene-solr/pull/685#discussion_r287003300
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java
##########
@@ -452,23 +453,30 @@ private void setBasicAuthHeader(SolrRequest solrRequest,
Request req) {
private Request makeRequest(SolrRequest solrRequest, String collection)
throws SolrServerException, IOException {
Request req = createRequest(solrRequest, collection);
- req.header(HttpHeader.ACCEPT_ENCODING, null);
Review comment:
I don't know the implications of moving the lines before/after
`setListeners` into the renamed `decorateRequest`. Clearing the
`ACCEPT_ENCODING` and adding `REQ_PRINCIPAL_KEY` changes the request?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
