[
https://issues.apache.org/jira/browse/LUCENE-8784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847381#comment-16847381
]
Jim Ferenczi commented on LUCENE-8784:
--------------------------------------
{quote}
By the way, would not it be better to leave the constructors that do not use
discardPunctuation parameters?
(Existing Nori users have to modify the code after uploading)
{quote}
Yes we should do that, otherwise it's a breaking change and we cannot push to
8x.
{quote}
I also added Javadoc for discardPunctuation in your patch. (KoreanAnalyzer,
KoreanTokenizerFactory)
{quote}
thanks!
{quote}
I developed KoreanNumberFilter by referring to JapaneseNumberFilter.
Please check my patch :D
{quote}
The patch looks good but we should iterate on this in a new issue. We try to do
one feature at a time in a single issue so let's add discardPunctuation in this
one and we can open a new one as a follow up to add the KoreanNumberFilter ?
> Nori(Korean) tokenizer removes the decimal point.
> ---------------------------------------------------
>
> Key: LUCENE-8784
> URL: https://issues.apache.org/jira/browse/LUCENE-8784
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Munkyu Im
> Priority: Major
> Attachments: LUCENE-8784.patch, LUCENE-8784.patch, LUCENE-8784.patch
>
>
> This is the same issue that I mentioned to
> [https://github.com/elastic/elasticsearch/issues/41401#event-2293189367]
> unlike standard analyzer, nori analyzer removes the decimal point.
> nori tokenizer removes "." character by default.
> In this case, it is difficult to index the keywords including the decimal
> point.
> It would be nice if there had the option whether add a decimal point or not.
> Like Japanese tokenizer does, Nori need an option to preserve decimal point.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
