shalinmangar commented on a change in pull request #685: SOLR-13434: OpenTracing support for Solr URL: https://github.com/apache/lucene-solr/pull/685#discussion_r288052632
########## File path: solr/contrib/jaegertracer-configurator/README.txt ########## @@ -0,0 +1,30 @@ +Welcome to Apache Solr Prometheus Exporter +======== + +Apache Solr Jaeger Tracer Configurator (solr-jaeger-tracer) provides a way for you to expose Solr's tracing to Jaeger. + +# Setup Jaeger Tracer Configurator + +Note that all library of solr-jaeger-tracer must be included in the classpath of all nodes then Jaeger tracer can be setup in `solr.xml` like this: + +``` +<tracerConfig name="tracerConfig" class="org.apache.solr.jaeger.JaegerTracerConfigurator"> + <double name="samplePercentage">100.0</double> Review comment: The default in the example shouldn't be set to 100%. Users might blindly copy the example and pay the price of tracing each request unknowingly. Perhaps set it to 5% to start? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
