s1monw opened a new pull request #688: LUCENE-8813: Ensure we never apply deletes from a closed DWPTDeleteQueue URL: https://github.com/apache/lucene-solr/pull/688 Today we don't have a strong protection that we add and apply deletes / updates on or from an already flushed delete queue. DWPTDeleteQueue instances are replaced once we do a full flush in order to reopen an NRT reader or commit the IndexWriter. In LUCENE-8813 we tripped an assert that used to protect us from such an situation but it didn't take all cornercases from concurrent flushing into account. This change adds a stronger protection and ensures that we neither apply a closed delete queue nor add any updates or deletes to it. This change also allows to speculativly freeze the global buffer that might return null now if the queue has already been closed. This is now possible since we ensure that we never see modifications to the queue after it's been closed and that happens right after the last DWPT for the ongoing full flush is done flushing.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
