anshumg commented on a change in pull request #689: SOLR-13489: Stop the leader
from trying to rejoin the election on ses…
URL: https://github.com/apache/lucene-solr/pull/689#discussion_r288255173
##########
File path: solr/core/src/java/org/apache/solr/cloud/ZkController.java
##########
@@ -368,8 +368,15 @@ public void command() {
}
cc.cancelCoreRecoveries();
-
- registerAllCoresAsDown(registerOnReconnect, false);
+
+ try {
+ registerAllCoresAsDown(registerOnReconnect, false);
+ } catch (SessionExpiredException e) {
+ // zk has to reconnect
+ throw e;
+ } catch (Exception e) {
+ log.warn("Exception while trying to register all cores as
DOWN", e);
Review comment:
don't you want to re-throw the exception here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
