dgarson commented on a change in pull request #685: SOLR-13434: OpenTracing support for Solr URL: https://github.com/apache/lucene-solr/pull/685#discussion_r288325802
########## File path: solr/contrib/jaegertracer-configurator/README.txt ########## @@ -0,0 +1,30 @@ +Welcome to Apache Solr Prometheus Exporter +======== + +Apache Solr Jaeger Tracer Configurator (solr-jaeger-tracer) provides a way for you to expose Solr's tracing to Jaeger. + +# Setup Jaeger Tracer Configurator + +Note that all library of solr-jaeger-tracer must be included in the classpath of all nodes then Jaeger tracer can be setup in `solr.xml` like this: + +``` +<tracerConfig name="tracerConfig" class="org.apache.solr.jaeger.JaegerTracerConfigurator"> Review comment: I'm not sure it's possible to have a `Tracer` per collection. If we want to sample a particular collection more aggressively than others, we should be able to perform our own *should-sample-check* and then manually start a trace, assuming OpenTracing supports this. This way we could differentiate the sample rate but still go through a single `Tracer`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
