jpountz commented on a change in pull request #675: SOLR-13350: Multi-threaded
search through an index
URL: https://github.com/apache/lucene-solr/pull/675#discussion_r288430225
##########
File path: lucene/core/src/java/org/apache/lucene/search/MultiCollector.java
##########
@@ -115,6 +116,11 @@ public ScoreMode scoreMode() {
return scoreMode;
}
+ // nocommit: need to raise a LUCENE jira for this?
+ public List<Collector> getCollectors() {
+ return Collections.unmodifiableList(Arrays.asList(collectors));
+ }
Review comment:
Maybe we don't need this if you maintain sub collectors as a
`List<Collector>` and only convert to a `MultiCollector` when you need to pass
them to `IndexSearcher`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
