noblepaul commented on a change in pull request #681: Fix SOLR-13347
URL: https://github.com/apache/lucene-solr/pull/681#discussion_r289826579
##########
File path: solr/core/src/java/org/apache/solr/update/TransactionLog.java
##########
@@ -102,6 +102,9 @@ public Object resolve(Object o, JavaBinCodec codec) throws
IOException {
};
public class LogCodec extends JavaBinCodec {
+
+ private static final byte UUID = 20;
Review comment:
There is a risk that somebody may accidently use the code `20` and break
`LogCodec`. So, let's keep this static field in JavabinCodec and say "This is
reserved to be used only in LogCodec"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
