[
https://issues.apache.org/jira/browse/SOLR-13452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856503#comment-16856503
]
Dawid Weiss commented on SOLR-13452:
------------------------------------
This looks very cool, Mark. One think I noticed is that you use File
constructor a lot, for example:
{code:java}
project.apply from: new File(rootProjectDir,
"buildSrc/common/configure-test.gradle") {code}
gradle has file(...) and files(...) which are handy constructs that are
project-relative. This is very often less verbose.
[https://docs.gradle.org/current/dsl/org.gradle.api.Project.html#org.gradle.api.Project:file(java.lang.Object)]
The above would just read (for example):
{code:java}
project.apply from:
rootProject.file("buildSrc/common/configure-test.gradle"){code}
> Update the lucene-solr build from Ivy+Ant+Maven (shadow build) to Gradle.
> -------------------------------------------------------------------------
>
> Key: SOLR-13452
> URL: https://issues.apache.org/jira/browse/SOLR-13452
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Build
> Reporter: Mark Miller
> Assignee: Mark Miller
> Priority: Major
> Fix For: master (9.0)
>
>
> I took some things from the great work that Dat did in
> [https://github.com/apache/lucene-solr/tree/jira/gradle] and took the ball a
> little further.
>
> When working with gradle in sub modules directly, I recommend
> [https://github.com/dougborg/gdub]
> This gradle branch uses the following plugin for version locking, version
> configuration and version consistency across modules:
> [https://github.com/palantir/gradle-consistent-versions]
>
> https://github.com/apache/lucene-solr/tree/jira/SOLR-13452_gradle_3
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
