[ 
https://issues.apache.org/jira/browse/SOLR-13507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856818#comment-16856818
 ] 

Erick Erickson edited comment on SOLR-13507 at 6/5/19 4:09 PM:
---------------------------------------------------------------

We  should probably also add comments to the code to warn devs in future 
against adding "addr" back in, or specifying {code}"*"{code}. NOTE: currently 
SolrTestCaseJ4 sets this property to "*". I was "iffy" about that.

Attached a  straw-man patch, could you take it from here? Haven't even tried to 
compile,  but it was faster than explaining ;)


was (Author: erickerickson):
We  should probably also add comments to the code to warn devs in future 
against adding "addr" back in, or specifying "*". NOTE: currently 
SolrTestCaseJ4 sets this property to "*". I was "iffy" about that.

Attached a  straw-man patch, could you take it from here? Haven't even tried to 
compile,  but it was faster than explaining ;)

> Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint.
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-13507
>                 URL: https://issues.apache.org/jira/browse/SOLR-13507
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Anshum Gupta
>            Assignee: Anshum Gupta
>            Priority: Major
>         Attachments: SOLR-13507.patch
>
>
> The addr parameter isn't needed and it should be removed from the code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to