audun commented on issue #681: Fix SOLR-13347 URL: https://github.com/apache/lucene-solr/pull/681#issuecomment-499414032 I think the style comments from the other PR applies here too, ie. don't include unrelated changed in the commit. That makes it so much easier to review and merge. The commit message should also be more descriptive, as you can see from the rest of the commit messages in the project. If you look in the commit history and you see a commit message like "Fix SOLR-12941", it means you need to look up what 12941 is. Compare that with the actual commit message: "SOLR-12941: Fix IndexSizeTrigger to correctly work with "aboveBytes" and "splitMethod=link" parameters."
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
