rmuir commented on issue #701: LUCENE-8836 Optimize DocValues TermsDict to continue scanning from the last position when possible URL: https://github.com/apache/lucene-solr/pull/701#issuecomment-499635591 maybe the better approach is top-down: for example starting at high level sorting/faceting algorithms, do they really go through any trouble to resolve ordinals in sequential order or do they just resolve the top-N in some arbitrary order by document count. IMO if this kind of code goes through the trouble to e.g. sort the top-N by ordinal, retrieve all the term metadata, then sort it back, then optimizations here make sense. But based on that code we can also determine if e.g. its only necessary to optimize say `seekCeil` versus also `seekExact`. It may simplify the low level code. If the high level code isn't actually doing work to resolve ordinals in ordinal-order, then it won't help to optimize seek. Merging code etc is already using `next()` which is clearly optimized for that case.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
