[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858669#comment-16858669
]
Uwe Schindler commented on LUCENE-8811:
---------------------------------------
This is why I am asking. I had a project and I implemented several visitors.
And neither the documentation nor the behavior looks consistent. From my
understanding, visitLeaf is called for every query you see. And visitTerms
additionally if there are terms. Check the code, Query.visit by default always
calls with itself and then delegates to a protected method.
> Add maximum clause count check to IndexSearcher rather than BooleanQuery
> ------------------------------------------------------------------------
>
> Key: LUCENE-8811
> URL: https://issues.apache.org/jira/browse/LUCENE-8811
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-8811.patch, LUCENE-8811.patch, LUCENE-8811.patch,
> LUCENE-8811.patch, LUCENE-8811.patch
>
>
> Currently we only check whether boolean queries have too many clauses.
> However there are other ways that queries may have too many clauses, for
> instance if you have boolean queries that have themselves inner boolean
> queries.
> Could we use the new Query visitor API to move this check from BooleanQuery
> to IndexSearcher in order to make this check more consistent across queries?
> See for instance LUCENE-8810 where a rewrite rule caused the maximum clause
> count to be hit even though the total number of leaf queries remained the
> same.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]