ctargett commented on a change in pull request #635: SOLR-13371 improve security chapters in refguide URL: https://github.com/apache/lucene-solr/pull/635#discussion_r291790995
########## File path: solr/solr-ref-guide/src/authentication-and-authorization-plugins.adoc ########## @@ -1,4 +1,4 @@ -= Authentication and Authorization Plugins += Configuring Authentication, Authorization and Auditlogging plugins Review comment: I prefer keeping the "auth" in the title, for the same reasons. I don't think we've worked out how to do redirects well - we don't really even have a functional 404 page. It's fine to keep the filename the same since it includes most of the reworked title, in my opinion, so I'm not worried about keeping it the way it is already. (We should figure out redirects, but it doesn't have to be done here.) Do you mean to use "Auditlogging" in the title though? It's a bit inconsistent in these edits - sometimes it's "auditlogging" and sometimes "audit logging". I feel like it should be "audit logging" wherever possible. An exception would be when referring to a class, and then I'll guess it would be something like "AuditLoggingPlugin". I think we could drop "Plugins" from the page title to be honest. The page is about configuring authentication, authorization and audit logging - the fact that's done with plugins doesn't need to be in the page title IMO. If you decide to keep "plugins" in the title, though, it should be capitalized so we maintain our standard of headline case for page and section titles. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
