[ 
https://issues.apache.org/jira/browse/LUCENE-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859239#comment-16859239
 ] 

Atri Sharma commented on LUCENE-8791:
-------------------------------------

bq. could we make the single-threaded constructor take a Collector rather than 
a CollectorManager and document that the one that takes an ExecutorService is 
expert and usually doesn't help significantly?

That has also been one of my main gripes with the approach that this patch 
takes -- the default interface takes an ExecutorManager. Maybe it is just a 
matter of personal taste, but it still catches the eye. It would be great if we 
could improve upon that

> Add CollectorRescorer
> ---------------------
>
>                 Key: LUCENE-8791
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8791
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Elbek Kamoliddinov
>            Priority: Major
>         Attachments: LUCENE-8791.patch, LUCENE-8791.patch, LUCENE-8791.patch, 
> LUCENE-8791.patch
>
>
> This is another implementation of query rescorer api (LUCENE-5489). It adds 
> rescoring functionality based on provided CollectorManager. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to