[
https://issues.apache.org/jira/browse/LUCENE-8812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859507#comment-16859507
]
Namgyu Kim commented on LUCENE-8812:
------------------------------------
I re-opened this issue because the error was occurred in branch_8x branch.
([https://jenkins.thetaphi.de/job/Lucene-Solr-8.x-Windows/298/])
After the error was found, the commit to fix the error was pushed.
The cause of the error was that when I wrote the test(TestKoreanNumberFilter),
I used Java 9 try-with-resources style, and the error was occurred in
branch_8x because it is based on Java 8.
So I disable it including the master branch, and when the 9.0 version is
officially released, I will rework it at that time.
And I made a slight mistake.
I did not mention the issue number when committing to the branch_8x branch.
I wanted to change the commit message, but it could not be changed because it
is a protected branch. (force push is blocked)
So I was forced to revert.
Anyway, both problems(error + wrong commit message) are all my fault, and I
will be careful.
I will resolve this issue when the Jenkins build is completed.
> add KoreanNumberFilter to Nori(Korean) Analyzer
> -----------------------------------------------
>
> Key: LUCENE-8812
> URL: https://issues.apache.org/jira/browse/LUCENE-8812
> Project: Lucene - Core
> Issue Type: New Feature
> Reporter: Namgyu Kim
> Assignee: Namgyu Kim
> Priority: Major
> Fix For: master (9.0), 8.2
>
> Attachments: LUCENE-8812.patch
>
>
> This is a follow-up issue to LUCENE-8784.
> The KoreanNumberFilter is a TokenFilter that normalizes Korean numbers to
> regular Arabic decimal numbers in half-width characters.
> Logic is similar to JapaneseNumberFilter.
> It should be able to cover the following test cases.
> 1) Korean Word to Number
> 십만이천오백 => 102500
> 2) 1 character conversion
> 일영영영 => 1000
> 3) Decimal Point Calculation
> 3.2천 => 3200
> 4) Comma between three digits
> 4,647.0010 => 4647.001
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
