[
https://issues.apache.org/jira/browse/SOLR-12282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859618#comment-16859618
]
Lucene/Solr QA commented on SOLR-12282:
---------------------------------------
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
52s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 53s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 48m
9s{color} | {color:green} core in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 54m 44s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12282 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12920962/SOLR-12282.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon
Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / fe58b6f |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | LTS |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/420/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/420/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> JSONResponseWriter should return Content-Type application/javascript for
> JSONP requests
> ---------------------------------------------------------------------------------------
>
> Key: SOLR-12282
> URL: https://issues.apache.org/jira/browse/SOLR-12282
> Project: Solr
> Issue Type: Improvement
> Components: Response Writers
> Reporter: Markus Schuch
> Priority: Minor
> Attachments: SOLR-12282.patch
>
>
> The JSONResponseWriter handles two purposes:
> * writing JSON responses (wt=json)
> * writing JSONP responses, namely JSON responses wrapped by a JavaScript
> function (wt=json&json.wrf=myFunction)
> The response writer returns the same Content-Type in both cases. (default:
> application/json)
> But for JSONP the correct Content-Type would be "application/javascript".
> The response type is configurable, but it is currently not possible to return
> the correct Content-Type in both cases with one configuration at the same
> time.
> The attached patch changes the default Content-Type to
> {{application/javascript; charset=utf-8}} for responses with wrapper
> functions (JSONP). If param {{content-type}} is configured, this Content-Type
> will be returned for both JSON and JSONP to ensure backward compatibility.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
